-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: flush or compact table and region functions #3363
feat: flush or compact table and region functions #3363
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3363 +/- ##
==========================================
- Coverage 84.90% 84.42% -0.49%
==========================================
Files 893 899 +6
Lines 147320 147833 +513
==========================================
- Hits 125084 124803 -281
- Misses 22236 23030 +794 |
@waynexia @zhongzc @fengjiachun Please take a look. |
SIze: XXL 🐶 |
rest LGTM |
Don't be afraid. Lots of boilerplate code and tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Zhenchi <[email protected]>
Co-authored-by: Zhenchi <[email protected]>
ea2bbec
to
4409efb
Compare
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR implements SQL functions:
flush_table(table_name)
to flush a table memtables into SST.compact_table(table_name)
to schedule a compaction task for a table.flush_region(region_id)
to flush a region by the region id.compact_region(region_id)
to schedule a compaction task for the region.For example:
Add:
admin_fn
attribute macro to simplify the definition of administration functions Define a procedural macro for implementing administration functions easily #3365procedure_state
andmigrate_region
function withadmin_fn
macro.Reduce some tech debts:
AffectedRows
definitions.table_idents_to_full_name
to the session crate etc.Checklist
Refer to a related PR or issue link (optional)
#3161 #2921 #3365
close #2899