Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Upgrade opensrv to 0.7.0 #3362

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

tisonkun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

TRIVIAL AS IS.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Feb 22, 2024
@tisonkun
Copy link
Collaborator Author

tisonkun commented Feb 22, 2024

opensrv bumps mysql_common version cause a X is not X cast issue. Let me take a closer look.

assert_eq!(mysql_columns_def[i], column.column_type());
                  0.32              0.31

@tisonkun tisonkun enabled auto-merge February 22, 2024 13:02
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e9a2b0a) 84.99% compared to head (d6369f0) 84.99%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3362      +/-   ##
==========================================
- Coverage   84.99%   84.99%   -0.01%     
==========================================
  Files         887      891       +4     
  Lines      145143   145528     +385     
==========================================
+ Hits       123369   123691     +322     
- Misses      21774    21837      +63     

@tisonkun tisonkun added this pull request to the merge queue Feb 22, 2024
Merged via the queue into GreptimeTeam:main with commit 41ee0cd Feb 22, 2024
17 checks passed
@tisonkun tisonkun deleted the upgrade-opensrv branch February 22, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants