-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: impl merge reader for DataParts #3361
feat: impl merge reader for DataParts #3361
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3361 +/- ##
==========================================
- Coverage 85.13% 85.01% -0.13%
==========================================
Files 887 892 +5
Lines 144657 146042 +1385
==========================================
+ Hits 123157 124160 +1003
- Misses 21500 21882 +382 |
dc1c86a
to
7805891
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DLJB
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR implements the merge reader for
DataParts
that merges data bacthes from all parts inside oneDataParts
, and yield batches according to pk weight and timestamp.Checklist
Refer to a related PR or issue link (optional)