Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl merge reader for DataParts #3361

Merged
merged 9 commits into from
Feb 23, 2024

Conversation

v0y4g3r
Copy link
Contributor

@v0y4g3r v0y4g3r commented Feb 22, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR implements the merge reader for DataParts that merges data bacthes from all parts inside one DataParts, and yield batches according to pk weight and timestamp.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@v0y4g3r v0y4g3r marked this pull request as ready for review February 22, 2024 09:47
@v0y4g3r v0y4g3r requested a review from evenyag February 22, 2024 09:47
@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 84.46215% with 78 lines in your changes are missing coverage. Please review.

Project coverage is 85.01%. Comparing base (7c88d72) to head (d83e3fe).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3361      +/-   ##
==========================================
- Coverage   85.13%   85.01%   -0.13%     
==========================================
  Files         887      892       +5     
  Lines      144657   146042    +1385     
==========================================
+ Hits       123157   124160    +1003     
- Misses      21500    21882     +382     

src/mito2/src/memtable/merge_tree/data.rs Outdated Show resolved Hide resolved
src/mito2/src/memtable/merge_tree/data.rs Outdated Show resolved Hide resolved
src/mito2/src/memtable/merge_tree/merger.rs Outdated Show resolved Hide resolved
src/mito2/src/memtable/merge_tree/merger.rs Outdated Show resolved Hide resolved
src/mito2/src/memtable/merge_tree/merger.rs Outdated Show resolved Hide resolved
src/mito2/src/memtable/merge_tree/merger.rs Outdated Show resolved Hide resolved
src/mito2/src/memtable/merge_tree/merger.rs Outdated Show resolved Hide resolved
@v0y4g3r v0y4g3r force-pushed the feat/merge-tree-parts-reader branch from dc1c86a to 7805891 Compare February 23, 2024 03:09
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

src/mito2/src/memtable/merge_tree/merger.rs Outdated Show resolved Hide resolved
src/mito2/src/memtable/merge_tree/merger.rs Outdated Show resolved Hide resolved
src/mito2/src/memtable/merge_tree/merger.rs Outdated Show resolved Hide resolved
@v0y4g3r v0y4g3r enabled auto-merge February 23, 2024 05:57
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DLJB

@v0y4g3r v0y4g3r added this pull request to the merge queue Feb 23, 2024
Merged via the queue into GreptimeTeam:main with commit 90e9b69 Feb 23, 2024
17 checks passed
@v0y4g3r v0y4g3r deleted the feat/merge-tree-parts-reader branch February 23, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants