Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix list_files_and_parse_table_name path issue on windows #3349

Merged
merged 5 commits into from
Feb 22, 2024

Conversation

evenyag
Copy link
Contributor

@evenyag evenyag commented Feb 21, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This PR converts the temp dir path to an object store style path in list_files_and_parse_table_name.

The C:\Users\abc\temp becomes C:/Users/abc/temp which is the supported form of us.

Users who'd like to use copy database on Windows should use unix-like path. See #3195

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

fixes #3301

@github-actions github-actions bot added the docs-not-required This change does not impact docs. label Feb 21, 2024
@evenyag evenyag marked this pull request as ready for review February 21, 2024 13:12
@evenyag evenyag requested review from v0y4g3r and WenyXu February 21, 2024 13:12
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f087a84) 85.24% compared to head (c22aada) 84.58%.
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3349      +/-   ##
==========================================
- Coverage   85.24%   84.58%   -0.67%     
==========================================
  Files         882      887       +5     
  Lines      144085   145144    +1059     
==========================================
- Hits       122823   122763      -60     
- Misses      21262    22381    +1119     

Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r added this pull request to the merge queue Feb 22, 2024
Merged via the queue into GreptimeTeam:main with commit 53105b9 Feb 22, 2024
26 of 35 checks passed
@v0y4g3r v0y4g3r deleted the fix/copy-db-test branch February 22, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

list_files_and_parse_table_name failed on windows
3 participants