-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Defines more structs and methods for a partitioned merge tree #3348
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3348 +/- ##
==========================================
- Coverage 85.24% 84.72% -0.52%
==========================================
Files 882 887 +5
Lines 144085 144657 +572
==========================================
- Hits 122823 122563 -260
- Misses 21262 22094 +832 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR defines more methods and structs related to
Partition
andShard
for the merge tree.Partition
provides two methodswrite_with_key()
andwrite_no_key()
to write a row with or without a primary keyscan()
methodShard
also has similar methods__table_id
column as partition keyfreeze()
,fork()
for the merge treeChecklist
Refer to a related PR or issue link (optional)