Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct the case sensitivity behavior for PromQL #3296

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Feb 7, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Use TableReference::bare to avoid unnecessary escaping or parsing

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: M labels Feb 7, 2024
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6b4be3a) 85.50% compared to head (582246b) 85.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3296      +/-   ##
==========================================
- Coverage   85.50%   85.08%   -0.43%     
==========================================
  Files         872      872              
  Lines      141719   141721       +2     
==========================================
- Hits       121174   120579     -595     
- Misses      20545    21142     +597     

Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
@waynexia waynexia enabled auto-merge February 8, 2024 03:22
@waynexia waynexia added this pull request to the merge queue Feb 8, 2024
Merged via the queue into GreptimeTeam:main with commit 2f98fa0 Feb 8, 2024
17 checks passed
@waynexia waynexia deleted the promql-case-sensitive branch February 8, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants