Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add insert/select generator & translator #3240

Merged
merged 4 commits into from
Jan 26, 2024
Merged

feat: add insert/select generator & translator #3240

merged 4 commits into from
Jan 26, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jan 25, 2024 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Add insert/select generator & translator

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#3174

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: M labels Jan 25, 2024
@WenyXu WenyXu changed the title feat: add insert/selector generator & translator feat: add insert/select generator & translator Jan 25, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 25, 2024 •
edited
Loading

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (673a4bd) 85.79% compared to head (81dfd69) 85.35%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3240      +/-   ##
==========================================
- Coverage   85.79%   85.35%   -0.44%     
==========================================
  Files         848      854       +6     
  Lines      139025   139191     +166     
==========================================
- Hits       119277   118808     -469     
- Misses      19748    20383     +635

@github-actions github-actions bot added Size: L and removed Size: M labels Jan 25, 2024
fengjiachun
fengjiachun approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Jan 26, 2024
Merged via the queue into GreptimeTeam:main with commit f99b087 Jan 26, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongzc zhongzc zhongzc approved these changes

@fengjiachun fengjiachun fengjiachun approved these changes

@waynexia waynexia Awaiting requested review from waynexia

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WenyXu @fengjiachun @zhongzc