Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tests-fuzz): add CreateTableExprGenerator & AlterTableExprGenerator #3182

Merged
merged 5 commits into from
Jan 19, 2024
Merged

feat(tests-fuzz): add CreateTableExprGenerator & AlterTableExprGenerator #3182

merged 5 commits into from
Jan 19, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jan 17, 2024 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  1. add CreateTableExprGenerator
  2. add AlterTableExprGenerator

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#3174

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: M labels Jan 17, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 17, 2024 •
edited
Loading

Codecov Report

Attention: 63 lines in your changes are missing coverage. Please review.

Comparison is base (7a1b856) 85.63% compared to head (568c717) 85.31%.
Report is 10 commits behind head on main.

❗ Current head 568c717 differs from pull request most recent head e8d39ff. Consider uploading reports for the commit e8d39ff to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3182      +/-   ##
==========================================
- Coverage   85.63%   85.31%   -0.33%     
==========================================
  Files         829      833       +4     
  Lines      135773   136318     +545     
==========================================
+ Hits       116273   116297      +24     
- Misses      19500    20021     +521

@github-actions github-actions bot added Size: L and removed Size: M labels Jan 17, 2024
@WenyXu WenyXu changed the title feat(tests-fuzz): add CreateTableExprGenerator feat(tests-fuzz): add CreateTableExprGenerator & AlterTableExprGenerator Jan 17, 2024
fengjiachun
fengjiachun approved these changes Jan 17, 2024
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests-fuzz/src/generator/alter_expr.rs Outdated Show resolved Hide resolved
tests-fuzz/src/generator/create_expr.rs Show resolved Hide resolved
@WenyXu WenyXu marked this pull request as draft January 18, 2024 02:02
@WenyXu WenyXu marked this pull request as ready for review January 18, 2024 10:29
@WenyXu
Copy link
Member Author

WenyXu commented Jan 18, 2024

@fengjiachun @waynexia I refactored the original AlterExprGenerator into three generators.

waynexia
waynexia approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Believe!

@waynexia waynexia added this pull request to the merge queue Jan 19, 2024
Merged via the queue into GreptimeTeam:main with commit 440cd00 Jan 19, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia approved these changes

@fengjiachun fengjiachun fengjiachun approved these changes

@zhongzc zhongzc Awaiting requested review from zhongzc

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WenyXu @fengjiachun @waynexia