-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mito): support write cache for index file #3144
Merged
killme2008
merged 4 commits into
GreptimeTeam:main
from
zhongzc:zhongzc/write-cache-support-index
Jan 12, 2024
Merged
feat(mito): support write cache for index file #3144
killme2008
merged 4 commits into
GreptimeTeam:main
from
zhongzc:zhongzc/write-cache-support-index
Jan 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs-not-required
This change does not impact docs.
Size: M
labels
Jan 11, 2024
zhongzc
force-pushed
the
zhongzc/write-cache-support-index
branch
2 times, most recently
from
January 11, 2024 10:36
f70325f
to
782724b
Compare
Signed-off-by: Zhenchi <[email protected]>
zhongzc
force-pushed
the
zhongzc/write-cache-support-index
branch
from
January 11, 2024 10:40
782724b
to
37ba7e0
Compare
7 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3144 +/- ##
==========================================
- Coverage 85.41% 84.97% -0.45%
==========================================
Files 823 823
Lines 134797 134917 +120
==========================================
- Hits 115138 114640 -498
- Misses 19659 20277 +618 |
22 tasks
evenyag
reviewed
Jan 11, 2024
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
evenyag
approved these changes
Jan 11, 2024
QuenKar
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Regarding the upcoming SST Inverted Index Creator for the Parquet Writer, its implementation unavoidably has to be coupled with
ParquetWriter::write_all
(for which I am very sorry, and if there's a better solution, I am open to suggestions). Consequently, depending on theWriteOptions
configuration,ParquetWriter::write_all
will generate either a Parquet data file or a Parquet data file plus a Puffin index file.This breaks some assumptions, for instance, with delete: the deletion of index files needs to be considered; with disk usage: the size of the index files needs to be taken into account. The recently added Write Cache feature also assumes that
ParquetWriter::write_all
only produces a single Parquet data file, an assumption that is unfortunately no longer correct.This PR is to fix the soon-to-be outdated assumptions of the Write Cache:
FileType
to the IndexKey in FileCache to indicate that the WriteCache contains not only Parquet files but also Puffin files.write_and_upload_sst
method upload Puffin files as well (if generated).SstIndexApplier
to benefit from local cache acceleration.Checklist
Refer to a related PR or issue link (optional)
#2705 #2965