-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: write and upload sst #3106
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs-not-required
This change does not impact docs.
Size: M
labels
Jan 5, 2024
QuenKar
force-pushed
the
feat/write-upload-sst
branch
from
January 8, 2024 02:11
3259d35
to
bcc421e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3106 +/- ##
==========================================
- Coverage 85.52% 85.07% -0.45%
==========================================
Files 818 818
Lines 133850 133971 +121
==========================================
- Hits 114474 113975 -499
- Misses 19376 19996 +620 |
evenyag
reviewed
Jan 8, 2024
evenyag
reviewed
Jan 9, 2024
QuenKar
force-pushed
the
feat/write-upload-sst
branch
from
January 9, 2024 06:30
6fb1f3c
to
4587bf7
Compare
QuenKar
force-pushed
the
feat/write-upload-sst
branch
from
January 9, 2024 10:33
4587bf7
to
fb454a8
Compare
killme2008
reviewed
Jan 10, 2024
Co-authored-by: dennis zhuang <[email protected]>
22 tasks
evenyag
reviewed
Jan 10, 2024
Co-authored-by: Yingwen <[email protected]>
killme2008
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
evenyag
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
part of #2965
write sst file to cache and upload it to remote object store
Checklist
Refer to a related PR or issue link (optional)
#2965