Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: metric engine support alter #3098

Merged

Conversation

fengjiachun
Copy link
Collaborator

@fengjiachun fengjiachun commented Jan 4, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  1. Support ALTER
  2. Procedure to ALTER logical table should acquire lock to physical table

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Close #2866

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: M labels Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (ec43b91) 85.61% compared to head (b5f8b53) 85.18%.
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3098      +/-   ##
==========================================
- Coverage   85.61%   85.18%   -0.43%     
==========================================
  Files         804      807       +3     
  Lines      131031   132172    +1141     
==========================================
+ Hits       112180   112591     +411     
- Misses      18851    19581     +730     

@fengjiachun fengjiachun mentioned this pull request Jan 5, 2024
14 tasks
src/common/meta/src/ddl/alter_table.rs Outdated Show resolved Hide resolved
src/common/meta/src/ddl_manager.rs Outdated Show resolved Hide resolved
@fengjiachun
Copy link
Collaborator Author

@MichaelScofield @WenyXu PTAL

@WenyXu
Copy link
Member

WenyXu commented Jan 5, 2024

Let's run the make fmt

@fengjiachun fengjiachun force-pushed the feat/alter-logical-table branch from 0d6a595 to f0b7587 Compare January 5, 2024 08:03
@MichaelScofield MichaelScofield added this pull request to the merge queue Jan 5, 2024
Merged via the queue into GreptimeTeam:main with commit bd1a5dc Jan 5, 2024
15 checks passed
@fengjiachun fengjiachun deleted the feat/alter-logical-table branch January 5, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Procedure to ALTER logical table should acquire lock to physical table
3 participants