Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add parquet metadata to cache #3097

Merged

Conversation

QuenKar
Copy link
Contributor

@QuenKar QuenKar commented Jan 4, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

add parquet metadata to SstMetaCache after flush or compact.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

Closes #2963

@github-actions github-actions bot added the docs-required This change requires docs update. label Jan 4, 2024
@github-actions github-actions bot added Size: S docs-not-required This change does not impact docs. and removed docs-required This change requires docs update. labels Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (96b6235) 85.66% compared to head (57133c4) 85.14%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3097      +/-   ##
==========================================
- Coverage   85.66%   85.14%   -0.53%     
==========================================
  Files         806      806              
  Lines      131563   131615      +52     
==========================================
- Hits       112707   112065     -642     
- Misses      18856    19550     +694     

@QuenKar QuenKar requested a review from evenyag January 5, 2024 06:22
Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia added this pull request to the merge queue Jan 9, 2024
Merged via the queue into GreptimeTeam:main with commit 225ae95 Jan 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Converts and caches parquet metadata returned by the parquet writer
3 participants