Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metric): implement role and region_disk_usage #3095

Merged
merged 3 commits into from
Jan 5, 2024
Merged

feat(metric): implement role and region_disk_usage #3095

merged 3 commits into from
Jan 5, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jan 4, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Filter out metric region stats

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#2070

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: S labels Jan 4, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 4, 2024 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d973cf8) 85.69% compared to head (8ab3d31) 85.17%.
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3095      +/-   ##
==========================================
- Coverage   85.69%   85.17%   -0.52%     
==========================================
  Files         806      806              
  Lines      131511   131646     +135     
==========================================
- Hits       112699   112132     -567     
- Misses      18812    19514     +702

@WenyXu WenyXu marked this pull request as draft January 4, 2024 08:28
@WenyXu WenyXu force-pushed the feat/filter-out-metric-engine-stats branch from 1e59c96 to 1f5dbc9 Compare January 4, 2024 09:25
@WenyXu WenyXu marked this pull request as ready for review January 4, 2024 09:26
@github-actions github-actions bot added Size: M and removed Size: S labels Jan 4, 2024
@WenyXu WenyXu changed the title feat: filter out metric region stats feat(metric): implement role and region_disk_usage Jan 4, 2024
fengjiachun
fengjiachun approved these changes Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WenyXu WenyXu force-pushed the feat/filter-out-metric-engine-stats branch from 817b650 to 2e42c84 Compare January 5, 2024 06:11
@WenyXu
Copy link
Member Author

WenyXu commented Jan 5, 2024

@MichaelScofield PTAL

@WenyXu WenyXu mentioned this pull request Jan 5, 2024
Closed
14 tasks
@MichaelScofield MichaelScofield added this pull request to the merge queue Jan 5, 2024
Merged via the queue into GreptimeTeam:main with commit cdc9021 Jan 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengjiachun fengjiachun fengjiachun approved these changes

@MichaelScofield MichaelScofield MichaelScofield approved these changes

@killme2008 killme2008 Awaiting requested review from killme2008

@waynexia waynexia Awaiting requested review from waynexia waynexia is a code owner

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WenyXu @MichaelScofield @fengjiachun