Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests-integration): add more region migration integration tests #3094

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jan 4, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Add more region migration integration test

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#2700

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: M labels Jan 4, 2024
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Geat TM!

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec43b91) 85.61% compared to head (6d4c5fe) 85.14%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3094      +/-   ##
==========================================
- Coverage   85.61%   85.14%   -0.47%     
==========================================
  Files         804      806       +2     
  Lines      131031   131511     +480     
==========================================
- Hits       112180   111978     -202     
- Misses      18851    19533     +682     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Jan 4, 2024
Merged via the queue into GreptimeTeam:main with commit f1a4750 Jan 4, 2024
16 checks passed
@WenyXu WenyXu mentioned this pull request Jan 4, 2024
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants