Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary result wrappings #3084

Conversation

ClSlaid
Copy link
Contributor

@ClSlaid ClSlaid commented Jan 3, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

remove unnecessary result wrappings

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

close #3079

@github-actions github-actions bot added docs-not-required This change does not impact docs. Invalid PR Title labels Jan 3, 2024
@ClSlaid ClSlaid changed the title patch: remove unnecessary result wrappings chore: remove unnecessary result wrappings Jan 3, 2024
@ClSlaid
Copy link
Contributor Author

ClSlaid commented Jan 3, 2024

@WenyXu PTAL.

Copy link
Member

@WenyXu WenyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b9302e4) 85.58% compared to head (1ff2386) 85.09%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3084      +/-   ##
==========================================
- Coverage   85.58%   85.09%   -0.50%     
==========================================
  Files         805      805              
  Lines      130658   130746      +88     
==========================================
- Hits       111822   111255     -567     
- Misses      18836    19491     +655     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Jan 3, 2024
Merged via the queue into GreptimeTeam:main with commit 5c66ce6 Jan 3, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The region_distribution should returns RegionDistribution instead of Result<RegionDistribution>
3 participants