Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(puffin): finish return written bytes #3082

Merged

Conversation

zhongzc
Copy link
Contributor

@zhongzc zhongzc commented Jan 3, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Puffin writer to return written bytes, to help the upper layer to track it.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: S labels Jan 3, 2024
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b9302e4) 85.58% compared to head (18714c5) 85.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3082      +/-   ##
==========================================
- Coverage   85.58%   85.08%   -0.50%     
==========================================
  Files         805      805              
  Lines      130658   130666       +8     
==========================================
- Hits       111822   111182     -640     
- Misses      18836    19484     +648     

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We'd better add some metrics for the indexing module.

@zhongzc zhongzc added this pull request to the merge queue Jan 3, 2024
Merged via the queue into GreptimeTeam:main with commit e1ad7af Jan 3, 2024
16 checks passed
@zhongzc zhongzc deleted the zhongzc/puffin-writer-written-bytes branch January 3, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants