Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inverted_index): Add applier builder to convert Expr to Predicates (Part 2) #3068

Conversation

zhongzc
Copy link
Contributor

@zhongzc zhongzc commented Jan 2, 2024

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Continue #3034:

  • Compile the following exprs to predicates
    • And
    • Or
    • Eq
    • Lt, LtEq, Gt, GtEq
    • RegexMatch
    • InList

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#2705

@zhongzc zhongzc self-assigned this Jan 2, 2024
@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: L labels Jan 2, 2024
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (c4d7b0d) 85.33% compared to head (7e5126c) 85.04%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3068      +/-   ##
==========================================
- Coverage   85.33%   85.04%   -0.29%     
==========================================
  Files         800      805       +5     
  Lines      129572   130658    +1086     
==========================================
+ Hits       110567   111115     +548     
- Misses      19005    19543     +538     

@zhongzc zhongzc force-pushed the zhongzc/inverted-index-integration-applier-builder-part-2 branch from b21459d to d0da869 Compare January 2, 2024 08:15
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008
Copy link
Contributor

@v0y4g3r @evenyag Please take a look

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Signed-off-by: Zhenchi <[email protected]>
@zhongzc zhongzc enabled auto-merge January 3, 2024 05:05
@zhongzc zhongzc added this pull request to the merge queue Jan 3, 2024
Merged via the queue into GreptimeTeam:main with commit b9302e4 Jan 3, 2024
16 checks passed
@zhongzc zhongzc deleted the zhongzc/inverted-index-integration-applier-builder-part-2 branch January 3, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants