Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: unify the injection of WAL option #3066

Merged
merged 5 commits into from
Jan 2, 2024
Merged

refactor: unify the injection of WAL option #3066

merged 5 commits into from
Jan 2, 2024

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Jan 2, 2024 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  1. Add prepare_wal_option
  2. use integer hashmap
  3. Unify the injection of WAL option

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#2700

@github-actions github-actions bot added Invalid PR Title docs-not-required This change does not impact docs. labels Jan 2, 2024
@WenyXu WenyXu changed the title Refactor/prepare wal options refactor: unify the injection of WAL option Jan 2, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 2, 2024 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f735f73) 85.35% compared to head (01dfd25) 84.86%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3066      +/-   ##
==========================================
- Coverage   85.35%   84.86%   -0.49%     
==========================================
  Files         800      800              
  Lines      129395   129630     +235     
==========================================
- Hits       110441   110008     -433     
- Misses      18954    19622     +668

fengjiachun
fengjiachun approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/common/meta/src/instruction.rs Show resolved Hide resolved
@MichaelScofield MichaelScofield added this pull request to the merge queue Jan 2, 2024
Merged via the queue into GreptimeTeam:main with commit 2b181e9 Jan 2, 2024
16 checks passed
@WenyXu WenyXu mentioned this pull request Jan 3, 2024
Closed
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengjiachun fengjiachun fengjiachun approved these changes

@MichaelScofield MichaelScofield MichaelScofield approved these changes

@niebayes niebayes Awaiting requested review from niebayes

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
Migration Procedure
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WenyXu @MichaelScofield @fengjiachun