-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: table route for metric engine #3053
feat: table route for metric engine #3053
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3053 +/- ##
==========================================
- Coverage 85.66% 85.12% -0.55%
==========================================
Files 805 804 -1
Lines 130889 131031 +142
==========================================
- Hits 112132 111536 -596
- Misses 18757 19495 +738 |
@waynexia PTAL |
eca7dc8
to
bdd39bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I conducted a test: after restarting, the two logical tables l1 and l2 could not be found.
bdd39bd
to
2d55f18
Compare
@fengjiachun PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM in general 👍
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Now metric engine table can be created. Basic insertion is supported:
Basic query is also supported:
Will add more tests in the next PR.
Checklist
Refer to a related PR or issue link (optional)
#2864