Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support PromQL function vector #3036

Merged
merged 5 commits into from
Jan 9, 2024
Merged

feat: support PromQL function vector #3036

merged 5 commits into from
Jan 9, 2024

Conversation

waynexia
Copy link
Member

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Implement vector function from PromQL.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@waynexia
produce vector plan
915de4e 
Signed-off-by: Ruihang Xia <[email protected]>
@waynexia
work with OR
a0ca568 
Signed-off-by: Ruihang Xia <[email protected]>
@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: L labels Dec 28, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 28, 2023 •
edited
Loading

Codecov Report

Attention: 137 lines in your changes are missing coverage. Please review.

Comparison is base (b58296d) 85.54% compared to head (356a6e0) 85.16%.
Report is 52 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3036      +/-   ##
==========================================
- Coverage   85.54%   85.16%   -0.38%     
==========================================
  Files         793      812      +19     
  Lines      128447   133027    +4580     
==========================================
+ Hits       109880   113299    +3419     
- Misses      18567    19728    +1161

killme2008
killme2008 reviewed Dec 29, 2023
View reviewed changes
src/promql/src/planner.rs Outdated Show resolved Hide resolved
src/promql/src/planner.rs Outdated Show resolved Hide resolved
src/promql/src/planner.rs Show resolved Hide resolved
@waynexia waynexia requested a review from killme2008 January 8, 2024 12:40
@waynexia
Copy link
Member Author

waynexia commented Jan 8, 2024

PTAL @killme2008

@waynexia waynexia enabled auto-merge January 9, 2024 03:37
killme2008
killme2008 approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynexia waynexia added this pull request to the merge queue Jan 9, 2024
Merged via the queue into GreptimeTeam:main with commit af0c4c0 Jan 9, 2024
16 checks passed
@waynexia waynexia deleted the prom-vector-fn branch January 9, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuanbohan yuanbohan yuanbohan approved these changes

@killme2008 killme2008 killme2008 approved these changes

@alili alili Awaiting requested review from alili

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waynexia @killme2008 @yuanbohan