refactor: merge standalone and metasrv table metadata allocators #3035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs-required
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3035 +/- ##
==========================================
- Coverage 85.50% 84.95% -0.55%
==========================================
Files 793 794 +1
Lines 128447 128555 +108
==========================================
- Hits 109825 109220 -605
- Misses 18622 19335 +713 |
MichaelScofield
added
docs-not-required
github-actions
bot
added
docs-required
niebayes
approved these changes
Dec 29, 2023
Co-authored-by: niebayes <[email protected]>
WenyXu
approved these changes
Dec 29, 2023
Co-authored-by: Weny Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
The two are same except for the peer allocation method. Merge them to reduce code duplication.
Checklist
Refer to a related PR or issue link (optional)