Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(TableRouteValue): add panic notes and type checks #3031

Merged
merged 14 commits into from
Dec 30, 2023
Merged

feat(TableRouteValue): add panic notes and type checks #3031

merged 14 commits into from
Dec 30, 2023

Conversation

AntiTopQuark
Copy link
Contributor

@AntiTopQuark AntiTopQuark commented Dec 28, 2023 •
edited by MichaelScofield
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

add panic notes and type checks for TableRouteValue

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

close #3016

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: M labels Dec 28, 2023
@AntiTopQuark
Copy link
Contributor Author

Previous PR:
#3023

@AntiTopQuark AntiTopQuark mentioned this pull request Dec 28, 2023
Closed
3 tasks
@waynexia waynexia changed the title feat(TableRouteValue): add panic notes and type checks #3023 feat(TableRouteValue): add panic notes and type checks Dec 28, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 28, 2023 •
edited
Loading

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (b58296d) 85.54% compared to head (5add9de) 84.89%.
Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3031      +/-   ##
==========================================
- Coverage   85.54%   84.89%   -0.65%     
==========================================
  Files         793      795       +2     
  Lines      128447   128791     +344     
==========================================
- Hits       109880   109339     -541     
- Misses      18567    19452     +885

WenyXu
WenyXu reviewed Dec 29, 2023
View reviewed changes
src/common/meta/src/key/table_route.rs Outdated Show resolved Hide resolved
src/common/meta/src/key/table_route.rs Outdated Show resolved Hide resolved
src/common/meta/src/key/table_route.rs Outdated Show resolved Hide resolved
src/common/meta/src/error.rs Outdated Show resolved Hide resolved
src/meta-srv/src/selector/load_based.rs Outdated Show resolved Hide resolved
WenyXu
WenyXu approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@WenyXu WenyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelScofield MichaelScofield added this pull request to the merge queue Dec 30, 2023
Merged via the queue into GreptimeTeam:main with commit 4460af8 Dec 30, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WenyXu WenyXu WenyXu approved these changes

@MichaelScofield MichaelScofield MichaelScofield approved these changes

@fengjiachun fengjiachun Awaiting requested review from fengjiachun

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check the table route type before calling physical_table_route
4 participants
@AntiTopQuark @MichaelScofield @WenyXu @waynexia