Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(remote_wal): add sqlness with kafka wal #3027

Merged
merged 12 commits into from
Dec 29, 2023

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Dec 28, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  1. Add kafka wal config to sqlness
  2. Add sqlness with kafka wal ci config

Run sqlness with kafka locally

Setup kafka standalone

  1. Go to workdir
cd tests-integration/fixtures/kafka/
  1. Run
docker compose -f docker-compose-standalone.yml up kafka -d

Run the Sqlness with kafka wal

cargo sqlness -w kafka -k localhost:9092

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added docs-required This change requires docs update. Size: M labels Dec 28, 2023
@WenyXu WenyXu force-pushed the test/sqlness-remote-wal branch from 848c35f to 9eafe0d Compare December 28, 2023 04:16
@WenyXu WenyXu force-pushed the test/sqlness-remote-wal branch from 9eafe0d to d507b85 Compare December 28, 2023 04:21
tests/runner/src/env.rs Show resolved Hide resolved
tests/runner/src/main.rs Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (301ffc1) 85.46% compared to head (e6ab974) 84.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3027      +/-   ##
==========================================
- Coverage   85.46%   84.95%   -0.51%     
==========================================
  Files         793      793              
  Lines      128592   128595       +3     
==========================================
- Hits       109896   109252     -644     
- Misses      18696    19343     +647     

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@killme2008 killme2008 added this pull request to the merge queue Dec 28, 2023
@killme2008 killme2008 removed this pull request from the merge queue due to a manual request Dec 28, 2023
@killme2008
Copy link
Contributor

Looks like the ci Sqlness Test with Kafka Wal fails sometimes. @WenyXu

@WenyXu
Copy link
Member Author

WenyXu commented Dec 28, 2023

Looks like the ci Sqlness Test with Kafka Wal fails sometimes. @WenyXu

Yes, I'm trying to fix it.

@WenyXu WenyXu force-pushed the test/sqlness-remote-wal branch from 3cda5df to 72b80e6 Compare December 28, 2023 13:04
@WenyXu WenyXu self-assigned this Dec 28, 2023
@niebayes niebayes changed the title test: add sqlness with kafka wal test(remote_wal): add sqlness with kafka wal Dec 28, 2023
@niebayes niebayes mentioned this pull request Dec 29, 2023
14 tasks
@niebayes niebayes added this pull request to the merge queue Dec 29, 2023
Merged via the queue into GreptimeTeam:main with commit e16f093 Dec 29, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-required This change requires docs update.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants