-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mito): Implement file cache #3022
Conversation
c0f2185
to
e7d235d
Compare
25c5c25
to
f04b7bb
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3022 +/- ##
==========================================
- Coverage 85.54% 85.05% -0.49%
==========================================
Files 793 794 +1
Lines 128447 128743 +296
==========================================
- Hits 109880 109508 -372
- Misses 18567 19235 +668 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little confused about the responsibilities. Cache is not responsible for storing files but deleting files, but it's not a big problem. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This PR implements a cache for files in the
WriteCache
. The design is similar to theReadCache
.The differences are
This cache has the following features:
{region_id}.{file_id}
as cache key and cached file nameChecklist
Refer to a related PR or issue link (optional)