Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement param parsing of SubmitRegionMigrationTaskHandler #3015

Merged

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Dec 27, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Implement param parsing of SubmitRegionMigrationTaskHandler

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

#2700

@github-actions github-actions bot added docs-not-required This change does not impact docs. Size: M labels Dec 27, 2023
@WenyXu WenyXu self-assigned this Dec 27, 2023
@fengjiachun fengjiachun added this to the v0.6 milestone Dec 27, 2023
@WenyXu WenyXu force-pushed the feat/region-migration-http-api branch from b928ce0 to b32f322 Compare December 27, 2023 07:34
@WenyXu WenyXu marked this pull request as ready for review December 27, 2023 07:34
@WenyXu WenyXu changed the title feat: implement param parsing of SubmitMigrationTaskHandler feat: implement param parsing of SubmitRegionMigrationTaskHandler Dec 27, 2023
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (718447c) 85.66% compared to head (cbe1fd4) 85.18%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3015      +/-   ##
===========================================
- Coverage    85.66%   85.18%   -0.48%     
===========================================
  Files          784      785       +1     
  Lines       126860   127002     +142     
===========================================
- Hits        108675   108190     -485     
- Misses       18185    18812     +627     

@WenyXu WenyXu mentioned this pull request Dec 27, 2023
39 tasks
@WenyXu
Copy link
Member Author

WenyXu commented Dec 27, 2023

@MichaelScofield PTAL

@MichaelScofield MichaelScofield added this pull request to the merge queue Dec 27, 2023
Merged via the queue into GreptimeTeam:develop with commit 840e946 Dec 27, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants