-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement region migration manager #3014
Merged
MichaelScofield
merged 3 commits into
GreptimeTeam:develop
from
WenyXu:feat/region-migration-manager
Dec 27, 2023
Merged
feat: implement region migration manager #3014
MichaelScofield
merged 3 commits into
GreptimeTeam:develop
from
WenyXu:feat/region-migration-manager
Dec 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
docs-not-required
This change does not impact docs.
Size: M
labels
Dec 27, 2023
WenyXu
force-pushed
the
feat/region-migration-manager
branch
from
December 27, 2023 05:07
05cea8c
to
72d6fa3
Compare
39 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #3014 +/- ##
===========================================
- Coverage 85.66% 85.15% -0.51%
===========================================
Files 784 785 +1
Lines 126860 127224 +364
===========================================
- Hits 108675 108338 -337
- Misses 18185 18886 +701 |
WenyXu
force-pushed
the
feat/region-migration-manager
branch
from
December 27, 2023 07:30
72d6fa3
to
542d531
Compare
WenyXu
force-pushed
the
feat/region-migration-manager
branch
from
December 27, 2023 07:41
542d531
to
b6cb83f
Compare
fengjiachun
approved these changes
Dec 27, 2023
Co-authored-by: JeremyHi <[email protected]>
@MichaelScofield PTAL |
MichaelScofield
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
More tests of managers will be introduced with integration tests(p.s. Previously, unit tests have covered region migration procedure flow-control tests)
Checklist
Refer to a related PR or issue link (optional)
#2700