Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make logging to stdout configurable #3003

Merged
merged 3 commits into from
Dec 26, 2023
Merged

feat: make logging to stdout configurable #3003

merged 3 commits into from
Dec 26, 2023

Conversation

MichaelScofield
Copy link
Collaborator

@MichaelScofield MichaelScofield commented Dec 26, 2023 •
edited by waynexia
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

as title

Also this PR makes some error logs leveled debug, because these error logs tend to recurring frequently.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link (optional)

close #2995

@codecov Codecov
Copy link

codecov bot commented Dec 26, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (99565a3) 85.69% compared to head (235232b) 85.18%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3003      +/-   ##
===========================================
- Coverage    85.69%   85.18%   -0.52%     
===========================================
  Files          784      784              
  Lines       126805   126806       +1     
===========================================
- Hits        108667   108019     -648     
- Misses       18138    18787     +649

killme2008
killme2008 reviewed Dec 26, 2023
View reviewed changes
src/operator/src/insert.rs Outdated Show resolved Hide resolved
src/operator/src/insert.rs Outdated Show resolved Hide resolved
src/servers/src/http.rs Outdated Show resolved Hide resolved
tests/runner/src/env.rs Show resolved Hide resolved
@killme2008 killme2008 added docs-not-required This change does not impact docs. C-documentation Improvements or additions to documentation IN THIS REPO docs-required This change requires docs update. and removed docs-not-required This change does not impact docs. labels Dec 26, 2023
@sunng87 sunng87 mentioned this pull request Dec 26, 2023
Closed
killme2008
killme2008 approved these changes Dec 26, 2023
View reviewed changes
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelScofield MichaelScofield mentioned this pull request Dec 26, 2023
Merged
2 tasks
fengys1996
fengys1996 approved these changes Dec 26, 2023
View reviewed changes
Copy link
Contributor

@fengys1996 fengys1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichaelScofield MichaelScofield added this pull request to the merge queue Dec 26, 2023
Merged via the queue into GreptimeTeam:develop with commit 196c06d Dec 26, 2023
37 of 42 checks passed
@MichaelScofield MichaelScofield deleted the feat/config-stdout-log branch December 26, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengys1996 fengys1996 fengys1996 approved these changes

@killme2008 killme2008 killme2008 approved these changes

@fengjiachun fengjiachun Awaiting requested review from fengjiachun

@WenyXu WenyXu Awaiting requested review from WenyXu

Assignees
No one assigned
Labels
C-documentation Improvements or additions to documentation IN THIS REPO docs-required This change requires docs update.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the stdout log appender configurable
3 participants
@MichaelScofield @killme2008 @fengys1996