refactor(remote_wal): add StandaloneWalConfig #3002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenyXu
added
docs-not-required
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #3002 +/- ##
===========================================
- Coverage 85.75% 85.18% -0.58%
===========================================
Files 783 783
Lines 126646 126691 +45
===========================================
- Hits 108609 107925 -684
- Misses 18037 18766 +729 |
niebayes
reviewed
Dec 26, 2023
niebayes
reviewed
Dec 26, 2023
MichaelScofield
approved these changes
Dec 26, 2023
niebayes
changed the title
WenyXu
force-pushed
the
feat/refine-standalone-wal-config
branch
from
318bd15 to
16901c8
Compare
niebayes
approved these changes
Dec 26, 2023
MichaelScofield
pushed a commit
to MichaelScofield/greptimedb
that referenced
this pull request
Dec 26, 2023
* feat: convert `FileMetaData` to `ParquetMetaData` (GreptimeTeam#2980) * feat: can convert Format FileMetaData to ParquetMetaData * test: parquet metadata equal * chore: test * chore: cr comment Co-authored-by: fys <[email protected]> * chore: cr comment * refactor: type name * chore: cr comment Co-authored-by: Yingwen <[email protected]> --------- Co-authored-by: fys <[email protected]> Co-authored-by: Yingwen <[email protected]> * refactor(remote_wal): add StandaloneWalConfig (GreptimeTeam#3002) * feat: integrate remote wal to standalone * fix: test * refactor: refactor standalone wal config * chore: change default kafka port to 9092 * chore: apply suggestions from CR --------- Co-authored-by: niebayes <[email protected]> --------- Co-authored-by: Wei <[email protected]> Co-authored-by: fys <[email protected]> Co-authored-by: Yingwen <[email protected]> Co-authored-by: Weny Xu <[email protected]> Co-authored-by: niebayes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Checklist
Refer to a related PR or issue link (optional)