Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): auto doc labeler job #2998

Merged
merged 2 commits into from
Dec 25, 2023
Merged

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Dec 25, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Add an action job to auto label "Doc not needed" on PR based on the checkbox in "Checklist".

This patch also adds a dedicated checkbox in PR template for "doc not needed"/"doc update required" tuples.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Closes #2997

@waynexia waynexia added the docs-not-required This change does not impact docs. label Dec 25, 2023
Copy link
Collaborator

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for giving it a try.

Copy link

codecov bot commented Dec 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (89129c9) 85.75% compared to head (f66765e) 85.32%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2998      +/-   ##
===========================================
- Coverage    85.75%   85.32%   -0.44%     
===========================================
  Files          783      783              
  Lines       126574   126634      +60     
===========================================
- Hits        108542   108045     -497     
- Misses       18032    18589     +557     

@waynexia
Copy link
Member Author

I've verified this config on waynexia#1

Signed-off-by: Ruihang Xia <[email protected]>
@waynexia waynexia requested review from sunng87 and nicecui December 25, 2023 12:27
@waynexia waynexia enabled auto-merge December 25, 2023 12:28
@sunng87
Copy link
Member

sunng87 commented Dec 25, 2023

Great! Never thought it has an official action for this.

@waynexia
Copy link
Member Author

Great! Never thought it has an official action for this.

Me too, I think pulsar also needs this 😋

Copy link
Collaborator

@nicecui nicecui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Great job! 👍

@waynexia waynexia added this pull request to the merge queue Dec 25, 2023
Merged via the queue into GreptimeTeam:develop with commit 3bd2f79 Dec 25, 2023
22 checks passed
@waynexia waynexia deleted the doc-labeler branch December 25, 2023 16:05
@nicecui nicecui mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve doc label experience
4 participants