Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adopt human-panic crash reports #2996

Merged
merged 3 commits into from
Dec 25, 2023
Merged

feat: adopt human-panic crash reports #2996

merged 3 commits into from
Dec 25, 2023

Conversation

tisonkun
Copy link
Collaborator

@tisonkun tisonkun commented Dec 25, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Demo panic:

Well, this is embarrassing.

GreptimeDB had a problem and crashed. To help us diagnose the problem you can send us a crash report.

We have generated a report file at "/var/folders/ts/160w4k_j5mv5bjk9rnjkzjpm0000gn/T/report-6bf3186e-a2dc-4309-9da3-fa1d59396e0a.toml". Submit an issue or email with the subject of "GreptimeDB Crash Report" and include the report as an attachment.

- Homepage: https://github.com/GreptimeTeam/greptimedb/discussions

We take privacy seriously, and do not perform any automated error collection. In order to improve the software, we rely on people to submit reports.

Thank you kindly!

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

close #1165

Copy link

codecov bot commented Dec 25, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (cf561df) 85.76% compared to head (555b669) 85.20%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2996      +/-   ##
===========================================
- Coverage    85.76%   85.20%   -0.56%     
===========================================
  Files          783      783              
  Lines       126638   126646       +8     
===========================================
- Hits        108607   107910     -697     
- Misses       18031    18736     +705     

@evenyag evenyag added the docs-not-required This change does not impact docs. label Dec 25, 2023
@waynexia waynexia added this pull request to the merge queue Dec 25, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 25, 2023
@tisonkun
Copy link
Collaborator Author

Merge queue fails with dep conflicts. Push a new commit to fix it.

@waynexia waynexia enabled auto-merge December 25, 2023 13:06
@waynexia waynexia added this pull request to the merge queue Dec 25, 2023
Merged via the queue into GreptimeTeam:develop with commit 417be13 Dec 25, 2023
13 checks passed
@tisonkun tisonkun deleted the issue-1165 branch December 26, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt human-panic
4 participants