feat: add '--store-key-prefix' to support multiple meta instances can use the same etcd backend #2988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyy17
requested review from
waynexia,
killme2008,
sunng87,
fengjiachun and
fengys1996
and removed request for
waynexia
zyy17
force-pushed
the
feat/add-store-key-prefix
branch
from
a0a1844 to
a7741aa
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2988 +/- ##
===========================================
- Coverage 85.87% 85.28% -0.60%
===========================================
Files 780 780
Lines 126184 126248 +64
===========================================
- Hits 108356 107666 -690
- Misses 17828 18582 +754 |
fengys1996
reviewed
Dec 25, 2023
… use the same etcd backend
zyy17
force-pushed
the
feat/add-store-key-prefix
branch
from
a7741aa to
5f0d5cf
Compare
|
Question: it this parameter only be passed by the command line arg? Can the users configure it in |
|
Oh, it seems that it cannot be configured through the toml file, I think we need a way with toml. @zyy17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
When deploying multiple clusters, it's more convenient and cost-effective to re-use the same etcd cluster.
In this PR, I added
--store-key-prefixwhich is specified by the admin in the metasrv to support that multiple metasrv instances can use the same etcd cluster without key confliction.Checklist
Refer to a related PR or issue link (optional)