-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support querying metric engine from frontend #2987
Merged
killme2008
merged 5 commits into
GreptimeTeam:develop
from
waynexia:query-metric-engine
Dec 25, 2023
Merged
feat: support querying metric engine from frontend #2987
killme2008
merged 5 commits into
GreptimeTeam:develop
from
waynexia:query-metric-engine
Dec 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2987 +/- ##
===========================================
- Coverage 85.93% 85.29% -0.65%
===========================================
Files 779 780 +1
Lines 125403 126261 +858
===========================================
- Hits 107770 107694 -76
- Misses 17633 18567 +934 |
fengjiachun
reviewed
Dec 25, 2023
Signed-off-by: Ruihang Xia <[email protected]>
killme2008
approved these changes
Dec 25, 2023
fengjiachun
approved these changes
Dec 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Support query metric table using
TableScan
.This patch also fixes a concurrent open region issue. Where the engine cannot tell if a logical region is valid until the corresponding physical region is opened.
Due to delete is not supported yet, sqlness case is not applicable now.
Checklist
Refer to a related PR or issue link (optional)
#2070