Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support querying metric engine from frontend #2987

Merged
merged 5 commits into from
Dec 25, 2023

Conversation

waynexia
Copy link
Member

@waynexia waynexia commented Dec 24, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Support query metric table using TableScan.

This patch also fixes a concurrent open region issue. Where the engine cannot tell if a logical region is valid until the corresponding physical region is opened.

Due to delete is not supported yet, sqlness case is not applicable now.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2070

Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
@waynexia waynexia added the docs-not-required This change does not impact docs. label Dec 24, 2023
Copy link

codecov bot commented Dec 24, 2023

Codecov Report

Attention: 95 lines in your changes are missing coverage. Please review.

Comparison is base (ff8c10e) 85.93% compared to head (527d76d) 85.29%.
Report is 11 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2987      +/-   ##
===========================================
- Coverage    85.93%   85.29%   -0.65%     
===========================================
  Files          779      780       +1     
  Lines       125403   126261     +858     
===========================================
- Hits        107770   107694      -76     
- Misses       17633    18567     +934     

@waynexia waynexia mentioned this pull request Dec 25, 2023
8 tasks
Signed-off-by: Ruihang Xia <[email protected]>
Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 added this pull request to the merge queue Dec 25, 2023
Merged via the queue into GreptimeTeam:develop with commit 48cd22d Dec 25, 2023
13 checks passed
@waynexia waynexia deleted the query-metric-engine branch December 25, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants