Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup kafka standalone in coverage test #2984

Merged
merged 2 commits into from
Dec 25, 2023

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Dec 23, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Setup a kafka standalone in CI coverage test

Get started

cd tests-integration/fixtures/kafka 

docker compose -f docker-compose-standalone.yml up

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@WenyXu WenyXu added the docs-not-required This change does not impact docs. label Dec 23, 2023
@WenyXu WenyXu force-pushed the chore/add-kafka-standalone branch from f217991 to 182fede Compare December 23, 2023 01:51
Copy link

codecov bot commented Dec 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d7b2e79) 85.87% compared to head (182fede) 85.46%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2984      +/-   ##
===========================================
- Coverage    85.87%   85.46%   -0.41%     
===========================================
  Files          780      780              
  Lines       126172   126194      +22     
===========================================
- Hits        108346   107853     -493     
- Misses       17826    18341     +515     

@niebayes niebayes enabled auto-merge December 25, 2023 11:18
@niebayes niebayes added this pull request to the merge queue Dec 25, 2023
Merged via the queue into GreptimeTeam:develop with commit 89129c9 Dec 25, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants