Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move some commonly referenced crates to workspace Cargo.toml #2981

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

niebayes
Copy link
Contributor

@niebayes niebayes commented Dec 22, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

As the title described.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@niebayes niebayes added the docs-not-required This change does not impact docs. label Dec 22, 2023
@niebayes niebayes enabled auto-merge December 22, 2023 09:04
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (830a91c) 85.86% compared to head (61729ae) 85.85%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2981      +/-   ##
===========================================
- Coverage    85.86%   85.85%   -0.01%     
===========================================
  Files          780      780              
  Lines       126088   126088              
===========================================
- Hits        108261   108249      -12     
- Misses       17827    17839      +12     

@niebayes niebayes added this pull request to the merge queue Dec 22, 2023
Merged via the queue into develop with commit 7d509e9 Dec 22, 2023
24 checks passed
@niebayes niebayes deleted the chore/reference_workspace_crates branch December 22, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants