-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a default internal schema #2974
feat: add a default internal schema #2974
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2974 +/- ##
===========================================
+ Coverage 84.78% 85.37% +0.58%
===========================================
Files 734 777 +43
Lines 114927 124930 +10003
===========================================
+ Hits 97440 106655 +9215
- Misses 17487 18275 +788 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to register this schema on metasrv? Others looks good to me
@waynexia If I understand correctly it should be done here: https://github.com/GreptimeTeam/greptimedb/pull/2974/files#diff-44b4862dfce3f3bb50a4845cd5bc075169fa40e0a678ff23ed9816c59c62ac06R308 |
@WenyXu @fengjiachun Please take a look |
Yes, it does. BTW, there is some future work that registering schema should be executed only on the metasrv leader. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Fixes #2964
This patch introduces a new built-in default schema as namespace of tables created by greptime applications. We have more information discussed in #2964 . In most cases, I think our user won't need to know about this schema.
Checklist
Refer to a related PR or issue link (optional)