Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a default internal schema #2974

Merged

Conversation

sunng87
Copy link
Member

@sunng87 sunng87 commented Dec 21, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Fixes #2964

This patch introduces a new built-in default schema as namespace of tables created by greptime applications. We have more information discussed in #2964 . In most cases, I think our user won't need to know about this schema.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@sunng87 sunng87 added cloud followup required docs-not-required This change does not impact docs. labels Dec 21, 2023
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bd9c2f2) 84.78% compared to head (b01862b) 85.37%.
Report is 108 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2974      +/-   ##
===========================================
+ Coverage    84.78%   85.37%   +0.58%     
===========================================
  Files          734      777      +43     
  Lines       114927   124930   +10003     
===========================================
+ Hits         97440   106655    +9215     
- Misses       17487    18275     +788     

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to register this schema on metasrv? Others looks good to me

@sunng87
Copy link
Member Author

sunng87 commented Dec 22, 2023

@killme2008
Copy link
Contributor

@WenyXu
Copy link
Member

WenyXu commented Dec 22, 2023

Do we need to register this schema on metasrv? Others looks good to me

Yes, it does. BTW, there is some future work that registering schema should be executed only on the metasrv leader.

Copy link
Collaborator

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengjiachun fengjiachun added this pull request to the merge queue Dec 22, 2023
Merged via the queue into GreptimeTeam:develop with commit 43f01cc Dec 22, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add built-in greptime_private schema by default
5 participants