Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused code for pruning row groups #2973

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

zhongzc
Copy link
Contributor

@zhongzc zhongzc commented Dec 21, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

prune_row_groups and prune_primary_key are unused.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@zhongzc zhongzc requested review from v0y4g3r and evenyag and removed request for v0y4g3r December 21, 2023 07:44
@zhongzc
Copy link
Contributor Author

zhongzc commented Dec 21, 2023

@v0y4g3r @evenyag PTAL

Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongzc zhongzc added the docs-not-required This change does not impact docs. label Dec 21, 2023
@v0y4g3r v0y4g3r enabled auto-merge December 21, 2023 07:50
@v0y4g3r v0y4g3r added this pull request to the merge queue Dec 21, 2023
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bad8918) 85.85% compared to head (dd0377b) 85.32%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2973      +/-   ##
===========================================
- Coverage    85.85%   85.32%   -0.54%     
===========================================
  Files          775      777       +2     
  Lines       124707   124919     +212     
===========================================
- Hits        107072   106585     -487     
- Misses       17635    18334     +699     

Merged via the queue into GreptimeTeam:develop with commit b5c5458 Dec 21, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants