feat(remote_wal): implement topic allocation #2970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niebayes
requested review from
MichaelScofield,
WenyXu,
killme2008,
fengjiachun and
v0y4g3r
8 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2970 +/- ##
===========================================
- Coverage 85.90% 85.80% -0.10%
===========================================
Files 780 780
Lines 125900 126088 +188
===========================================
+ Hits 108157 108195 +38
- Misses 17743 17893 +150 |
WenyXu
reviewed
Dec 21, 2023
killme2008
reviewed
Dec 21, 2023
v0y4g3r
reviewed
Dec 21, 2023
WenyXu
reviewed
Dec 21, 2023
evenyag
reviewed
Dec 21, 2023
fengjiachun
reviewed
Dec 21, 2023
niebayes
requested review from
killme2008,
MichaelScofield,
fengjiachun,
v0y4g3r,
evenyag and
waynexia
MichaelScofield
approved these changes
Dec 22, 2023
WenyXu
reviewed
Dec 22, 2023
| # Number of partitions per topic. | ||
| # num_partitions = 1 | ||
| # Expected number of replicas of each partition. | ||
| # replication_factor = 3 | ||
| # Above which a topic creation operation will be cancelled. |
There was a problem hiding this comment.
Let's use more concise words.
Nit(Non-blocking):
Suggested change
| # Above which a topic creation operation will be cancelled. | |
| # The timeout of topic creation |
Comment on lines
+202
to
+204
| if let Err(e) = self.wal_options_allocator.start().await { | ||
| error!(e; "Failed to start wal options allocator"); | ||
| } |
There was a problem hiding this comment.
Nit(Non-blocking):
We should ensure the start will only be executed once in the life cycle. We can improve this in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
WalOptionsAllocatorso wal options could be allocated while the metasrv is handling a create table request.TODO
Checklist
Refer to a related PR or issue link (optional)
Tracing issue for Kafka remote wal: #2722