Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add user-doc label checker #2967

Merged
merged 1 commit into from
Dec 21, 2023
Merged

ci: add user-doc label checker #2967

merged 1 commit into from
Dec 21, 2023

Conversation

nicecui
Copy link
Collaborator

@nicecui nicecui commented Dec 20, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

In order to catching the imapaction of the PRs to user documentation, label Doc update required or Doc not needed should be added before merging.

If the label Doc update required is added, the doc-issue.yml workflow will add a issue to docs repo.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@nicecui nicecui added the docs-not-required This change does not impact docs. label Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d2f49cb) 85.81% compared to head (168788f) 85.29%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2967      +/-   ##
===========================================
- Coverage    85.81%   85.29%   -0.53%     
===========================================
  Files          767      770       +3     
  Lines       123745   123951     +206     
===========================================
- Hits        106193   105725     -468     
- Misses       17552    18226     +674     

@sunng87
Copy link
Member

sunng87 commented Dec 20, 2023

It seems we changed type case of doc updated required, you might want to update this line as well: https://github.com/GreptimeTeam/greptimedb/blob/develop/.github/workflows/doc-issue.yml#L13

@killme2008 killme2008 requested a review from zyy17 December 20, 2023 09:55
@killme2008 killme2008 added this pull request to the merge queue Dec 21, 2023
Merged via the queue into GreptimeTeam:develop with commit bad8918 Dec 21, 2023
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-not-required This change does not impact docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants