Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: SelectorType use snake_case #2962

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

fengjiachun
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

As the title said

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@fengjiachun fengjiachun requested review from fengys1996, WenyXu and waynexia and removed request for fengys1996 and WenyXu December 19, 2023 13:15
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #2962 (9b4426b) into develop (c7b3677) will decrease coverage by 0.53%.
Report is 1 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2962      +/-   ##
===========================================
- Coverage    85.80%   85.28%   -0.53%     
===========================================
  Files          762      767       +5     
  Lines       123194   123633     +439     
===========================================
- Hits        105709   105435     -274     
- Misses       17485    18198     +713     

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag added this pull request to the merge queue Dec 20, 2023
Merged via the queue into GreptimeTeam:develop with commit 5f8c175 Dec 20, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants