Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inverted_index.create): add index creator #2960

Merged

Conversation

zhongzc
Copy link
Contributor

@zhongzc zhongzc commented Dec 19, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

  • Add the InvertedIndexCreator trait to handle the creation of indexes for multiple columns with multiple rows, and relies on the InvertedIndexWriter to ultimately complete the construction of the index.
    • Add the SortIndexCreator implementation, which internally maintains the sorting of multiple columns.
  • Adjust the finish function in the InvertedIndexWriter trait to fit the index construction process.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

#2705

Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #2960 (534774f) into develop (83de399) will decrease coverage by 0.51%.
The diff coverage is 94.46%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2960      +/-   ##
===========================================
- Coverage    85.81%   85.30%   -0.51%     
===========================================
  Files          762      765       +3     
  Lines       123123   123353     +230     
===========================================
- Hits        105653   105222     -431     
- Misses       17470    18131     +661     

Copy link
Member

@waynexia waynexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM 🚀

src/index/src/inverted_index/format/writer.rs Show resolved Hide resolved
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongzc zhongzc added this pull request to the merge queue Dec 20, 2023
Merged via the queue into GreptimeTeam:develop with commit 7d1724f Dec 20, 2023
13 checks passed
@zhongzc zhongzc deleted the zhongzc/inverted-index-create-creator branch December 20, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants