-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inverted_index.create): add index creator #2960
Merged
zhongzc
merged 21 commits into
GreptimeTeam:develop
from
zhongzc:zhongzc/inverted-index-create-creator
Dec 20, 2023
Merged
feat(inverted_index.create): add index creator #2960
zhongzc
merged 21 commits into
GreptimeTeam:develop
from
zhongzc:zhongzc/inverted-index-create-creator
Dec 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… files Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
…ls to poll Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
This reverts commit 63cb5bd.
Signed-off-by: Zhenchi <[email protected]>
Signed-off-by: Zhenchi <[email protected]>
…ndex-create-creator
Signed-off-by: Zhenchi <[email protected]>
7 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2960 +/- ##
===========================================
- Coverage 85.81% 85.30% -0.51%
===========================================
Files 762 765 +3
Lines 123123 123353 +230
===========================================
- Hits 105653 105222 -431
- Misses 17470 18131 +661 |
waynexia
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others LGTM 🚀
killme2008
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
InvertedIndexCreator
trait to handle the creation of indexes for multiple columns with multiple rows, and relies on theInvertedIndexWriter
to ultimately complete the construction of the index.SortIndexCreator
implementation, which internally maintains the sorting of multiple columns.finish
function in theInvertedIndexWriter
trait to fit the index construction process.Checklist
Refer to a related PR or issue link (optional)
#2705