-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remote_wal): add skeleton for remote wal related to datanode #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
niebayes
requested review from
killme2008,
MichaelScofield,
fengjiachun,
v0y4g3r,
evenyag and
waynexia
December 16, 2023 10:49
v0y4g3r
reviewed
Dec 18, 2023
evenyag
reviewed
Dec 18, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2941 +/- ##
===========================================
- Coverage 85.85% 85.70% -0.16%
===========================================
Files 770 775 +5
Lines 123951 124230 +279
===========================================
+ Hits 106424 106471 +47
- Misses 17527 17759 +232 |
killme2008
reviewed
Dec 19, 2023
niebayes
requested review from
killme2008,
MichaelScofield,
v0y4g3r and
evenyag
December 20, 2023 08:33
killme2008
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
v0y4g3r
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
RegionInfo
ofDatanodeTableValue
, and will be passed to datanodes throughRegionCreateRequest
. See: feat(remote_wal): add skeleton for remote wal related to meta srv #2933RegionInfo
inDatanodeTableValue
. Those wal options are then merged into region options and passed to region workers.MitoRegion
to be used during writing to a region.RegionWriteRequest
, it constructs wal entry namespaces with wal options. Entries are then written into the log store.Checklist
Refer to a related PR or issue link (optional)