feat: add CatchupRequest to engine #2939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WenyXu
requested review from
MichaelScofield,
fengjiachun,
evenyag,
waynexia and
zhongzc
39 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2939 +/- ##
===========================================
- Coverage 85.82% 85.37% -0.45%
===========================================
Files 775 777 +2
Lines 124230 125219 +989
===========================================
+ Hits 106621 106910 +289
- Misses 17609 18309 +700 |
WenyXu
commented
Dec 15, 2023
WenyXu
force-pushed
the
feat/mito-handle-upgrade-candidate
branch
2 times, most recently
from
202a620 to
919f71d
Compare
evenyag
reviewed
Dec 18, 2023
WenyXu
force-pushed
the
feat/mito-handle-upgrade-candidate
branch
from
1f2d1ab to
bc962d6
Compare
WenyXu
changed the title
set_writable_gracefully for engine
WenyXu
force-pushed
the
feat/mito-handle-upgrade-candidate
branch
5 times, most recently
from
b2757ae to
206982c
Compare
|
@MichaelScofield @evenyag PTAL |
WenyXu
force-pushed
the
feat/mito-handle-upgrade-candidate
branch
3 times, most recently
from
0da0b6a to
a961a00
Compare
feat: reopen region before replay if need
WenyXu
force-pushed
the
feat/mito-handle-upgrade-candidate
branch
from
a961a00 to
2c57764
Compare
|
@MichaelScofield @evenyag PTAL |
evenyag
reviewed
Dec 21, 2023
WenyXu
force-pushed
the
feat/mito-handle-upgrade-candidate
branch
2 times, most recently
from
07d5c0f to
bb4c21a
Compare
|
@MichaelScofield @evenyag PTAL |
WenyXu
force-pushed
the
feat/mito-handle-upgrade-candidate
branch
from
bb4c21a to
981c306
Compare
evenyag
reviewed
Dec 21, 2023
Co-authored-by: Yingwen <[email protected]>
MichaelScofield
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Add CatchupRequest; it makes a readonly region to catch up to leader region changes.
Checklist
Refer to a related PR or issue link (optional)
#2700