fix: support tailing commas in SQL #2913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2913 +/- ##
===========================================
- Coverage 85.11% 84.53% -0.58%
===========================================
Files 756 756
Lines 119511 119513 +2
===========================================
- Hits 101719 101028 -691
- Misses 17792 18485 +693 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Because some bug in sqlparser, sql like
SELECT foo, bar, FROM bazwith tailing commas will be wrongly parse toSELECT foo, bar, FROM AS bazEnable
trailing_commasin sqlparser to avoid such error.Checklist
Refer to a related PR or issue link (optional)