Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore MySQL client sent SELECT $$ #2896

Merged
merged 1 commit into from
Dec 11, 2023
Merged

chore: ignore MySQL client sent SELECT $$ #2896

merged 1 commit into from
Dec 11, 2023

Conversation

tisonkun
Copy link
Collaborator

@tisonkun tisonkun commented Dec 9, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This closes #2514.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Merging #2896 (f7b0b07) into develop (5a99f09) will decrease coverage by 0.60%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2896      +/-   ##
===========================================
- Coverage    85.06%   84.47%   -0.60%     
===========================================
  Files          753      753              
  Lines       119059   119062       +3     
===========================================
- Hits        101281   100576     -705     
- Misses       17778    18486     +708     

Copy link
Member

@WenyXu WenyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @tisonkun, Almost LGTM. Maybe it's better to add a simple sqlness for this case, If you don't mind ❤️

@tisonkun
Copy link
Collaborator Author

tisonkun commented Dec 9, 2023

@WenyXu Thanks for your review! This patch is active for MySQL interface only. I try sqlness case locally but it doesn't seem go through the MySQL server logic.

Is there other proper place to write IT cases?

@WenyXu
Copy link
Member

WenyXu commented Dec 9, 2023

@WenyXu Thanks for your review! This patch is active for MySQL interface only. I try sqlness case locally but it doesn't seem go through the MySQL server logic.

Is there other proper place to write IT cases?

Oh, My bad. You reminded me that our sqlness is using the gRPC protocol. Let's go ahead and leave this IT case as future work.

Copy link
Contributor

@QuenKar QuenKar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evenyag evenyag added this pull request to the merge queue Dec 11, 2023
Merged via the queue into GreptimeTeam:develop with commit 73227bb Dec 11, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error log: Failed to execute query: select $$
4 participants