Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mysql version function result #2884

Merged
merged 1 commit into from
Dec 6, 2023
Merged

fix: mysql version function result #2884

merged 1 commit into from
Dec 6, 2023

Conversation

tisonkun
Copy link
Collaborator

@tisonkun tisonkun commented Dec 6, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

This closes #2846.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Copy link
Collaborator Author

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TRIVIAL AS IS. I don't think it worth to write a test, unless we have a Docker test fixture to use.

@waynexia waynexia requested review from waynexia and QuenKar December 6, 2023 13:52
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #2884 (5f61c74) into develop (b3ffe5c) will decrease coverage by 0.53%.
Report is 7 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2884      +/-   ##
===========================================
- Coverage    84.86%   84.34%   -0.53%     
===========================================
  Files          745      749       +4     
  Lines       117222   117893     +671     
===========================================
- Hits         99482    99433      -49     
- Misses       17740    18460     +720     

@waynexia waynexia enabled auto-merge December 6, 2023 14:29
@waynexia waynexia added this pull request to the merge queue Dec 6, 2023
Merged via the queue into GreptimeTeam:develop with commit ea80570 Dec 6, 2023
13 checks passed
@tisonkun tisonkun deleted the fix-mysql-version branch December 14, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

version unknown with docker run
3 participants