Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: impl date_add/date_sub functions #2881

Merged
merged 11 commits into from
Dec 7, 2023
Merged

feat: impl date_add/date_sub functions #2881

merged 11 commits into from
Dec 7, 2023

Conversation

killme2008
Copy link
Contributor

@killme2008 killme2008 commented Dec 6, 2023 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Impls date_add and date_sub functions to add an interval to Timestamp/Date/DateTime values.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Close #2593

@killme2008 killme2008 marked this pull request as ready for review December 6, 2023 08:26
@codecov Codecov
Copy link

codecov bot commented Dec 6, 2023 •
edited
Loading

Codecov Report

Merging #2881 (9ab9ffc) into develop (f9e7762) will decrease coverage by 0.32%.
Report is 6 commits behind head on develop.
The diff coverage is 91.75%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2881      +/-   ##
===========================================
- Coverage    84.73%   84.42%   -0.32%     
===========================================
  Files          749      753       +4     
  Lines       117900   118553     +653     
===========================================
+ Hits         99900   100084     +184     
- Misses       18000    18469     +469

QuenKar
QuenKar approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@QuenKar QuenKar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@killme2008 killme2008 marked this pull request as draft December 6, 2023 11:36
@killme2008 killme2008 marked this pull request as ready for review December 7, 2023 02:45
@killme2008
Copy link
Contributor Author

@zhongzc @QuenKar @fengjiachun Please take another look. I fixed the wrong behavior of the previous implementation.

@waynexia waynexia added this pull request to the merge queue Dec 7, 2023
Merged via the queue into GreptimeTeam:develop with commit 43f32f4 Dec 7, 2023
21 checks passed
@killme2008 killme2008 deleted the feature/date-functions branch January 16, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuenKar QuenKar QuenKar approved these changes

@fengjiachun fengjiachun fengjiachun left review comments

@zhongzc zhongzc zhongzc approved these changes

@v0y4g3r v0y4g3r Awaiting requested review from v0y4g3r

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Supports date_add and date_sub function
5 participants
@killme2008 @fengjiachun @zhongzc @QuenKar @waynexia