Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace opendal PrometheusLayer #2861

Merged
merged 4 commits into from
Dec 5, 2023
Merged

fix: replace opendal PrometheusLayer #2861

merged 4 commits into from
Dec 5, 2023

Conversation

Taylor-lagrange
Copy link
Contributor

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Use self implementation of PrometheusMetricsLayer to replace opendal's PrometheusLayer to solve the crash caused by repeated registration of metrics under multiple object_stores ( solve by use lazy_static), and add the opendal_ prefix to the metric.

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #2861 (4aa6064) into develop (6344b1e) will decrease coverage by 0.47%.
Report is 2 commits behind head on develop.
The diff coverage is 38.80%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2861      +/-   ##
===========================================
- Coverage    84.78%   84.32%   -0.47%     
===========================================
  Files          745      746       +1     
  Lines       117025   117635     +610     
===========================================
- Hits         99223    99197      -26     
- Misses       17802    18438     +636     

Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/object-store/src/layers/prometheus.rs Show resolved Hide resolved
@killme2008 killme2008 requested review from evenyag and zhongzc December 4, 2023 12:22
Copy link
Contributor

@zhongzc zhongzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhongzc zhongzc added this pull request to the merge queue Dec 5, 2023
Merged via the queue into GreptimeTeam:develop with commit aa89d9d Dec 5, 2023
13 checks passed
@Taylor-lagrange Taylor-lagrange deleted the fix-opendal-metrics branch December 5, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants