-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace opendal PrometheusLayer
#2861
fix: replace opendal PrometheusLayer
#2861
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2861 +/- ##
===========================================
- Coverage 84.78% 84.32% -0.47%
===========================================
Files 745 746 +1
Lines 117025 117635 +610
===========================================
- Hits 99223 99197 -26
- Misses 17802 18438 +636 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
Use self implementation of
PrometheusMetricsLayer
to replaceopendal
'sPrometheusLayer
to solve the crash caused by repeated registration of metrics under multipleobject_store
s ( solve by uselazy_static
), and add theopendal_
prefix to the metric.Checklist
Refer to a related PR or issue link (optional)