feat: drop if exists #2859
Merged
feat: drop if exists #2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tison <[email protected]>
Signed-off-by: tison <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #2859 +/- ##
===========================================
- Coverage 84.74% 84.40% -0.35%
===========================================
Files 740 740
Lines 115767 115796 +29
===========================================
- Hits 98105 97735 -370
- Misses 17662 18061 +399 |
|
Maybe I should add some e2e tests. But let's first take a look at the impl direction. |
WenyXu
approved these changes
Dec 4, 2023
Signed-off-by: tison <[email protected]>
|
Updated. PTAL again. |
MichaelScofield
approved these changes
Dec 5, 2023
|
Drop table procedures cannot run concurrently because they acquire the same procedure lock key. The key locks on the table name. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Is this an unstable case - https://github.com/GreptimeTeam/greptimedb/actions/runs/7095139148/job/19311581914? Since we pass at the first attempt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
This closes #2794.
@zuston it happens that I have some time to review this issue, if you're working on this issue, feel free to take any value from my PR and prioritize your patch.
@sunng87 I noticed that we actually check table existence before submit DropTable DDL task. If so, we can simply filter drop table tasks in
StatemenExecutor::drop_tableand assert table exists for the following producer.Also, I'd like to confirm whether DDL task procedures can run concurrently. That is, if two
DROP TABLE tcan run concurrently withtexists. If so, we may need some lock/sync when removing table metadata.Checklist
Refer to a related PR or issue link (optional)