Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add logs and metrics #2858

Merged
merged 6 commits into from
Dec 4, 2023

Conversation

WenyXu
Copy link
Member

@WenyXu WenyXu commented Dec 2, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Add some logs and metrics for heartbeat handling

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Merging #2858 (4981860) into develop (781f242) will decrease coverage by 0.30%.
The diff coverage is 73.17%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2858      +/-   ##
===========================================
- Coverage    84.74%   84.44%   -0.30%     
===========================================
  Files          740      740              
  Lines       115767   115841      +74     
===========================================
- Hits         98105    97822     -283     
- Misses       17662    18019     +357     

Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/datanode/src/heartbeat.rs Outdated Show resolved Hide resolved
src/datanode/src/heartbeat.rs Outdated Show resolved Hide resolved
@MichaelScofield MichaelScofield added this pull request to the merge queue Dec 4, 2023
Merged via the queue into GreptimeTeam:develop with commit c26f2f9 Dec 4, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants