Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: improve user experience on setting compression type #2834

Closed
wants to merge 1 commit into from
Closed

revert: improve user experience on setting compression type #2834

wants to merge 1 commit into from

Conversation

killme2008
Copy link
Contributor

Reverts #2765

@killme2008 killme2008 marked this pull request as ready for review November 29, 2023 03:11
@github-actions github-actions bot added the breaking-change This pull request contains breaking changes. label Nov 29, 2023
@killme2008 killme2008 requested a review from evenyag November 29, 2023 03:12
@killme2008 killme2008 changed the title Revert "fix!: improve user experience on setting compression type" revert: improve user experience on setting compression type Nov 29, 2023
@github-actions github-actions bot removed Invalid PR Title breaking-change This pull request contains breaking changes. labels Nov 29, 2023
evenyag
evenyag approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@evenyag evenyag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. We'd better not to break existing config files...

@WenyXu
Copy link
Member

WenyXu commented Nov 29, 2023

Standalone config still needs to fix

greptimedb/config/standalone.example.toml

Line 137 in d0d0f09

manifest_compress_type = "uncompressed"

@codecov Codecov
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #2834 (9f85ad1) into develop (d0d0f09) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2834      +/-   ##
===========================================
- Coverage    84.79%   84.78%   -0.01%     
===========================================
  Files          734      734              
  Lines       115132   115132              
===========================================
- Hits         97630    97619      -11     
- Misses       17502    17513      +11

@evenyag
Copy link
Contributor

evenyag commented Nov 29, 2023

We can use deserialize_struct_case_insensitive in the serde_aux crate to support case-insensitive deserialization.
https://docs.rs/serde-aux/latest/serde_aux/container_attributes/fn.deserialize_struct_case_insensitive.html

@killme2008 killme2008 closed this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evenyag evenyag evenyag approved these changes

@waynexia waynexia Awaiting requested review from waynexia

@WenyXu WenyXu Awaiting requested review from WenyXu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@killme2008 @WenyXu @evenyag